[maven-4.0.x] Fix mvn script expanding ${...} in CLI arguments#12095
Merged
Conversation
The eval in the mvn script causes shell expansion of ${...} patterns
in user-provided arguments. Pass user arguments directly via "$@"
instead of concatenating them into the eval string. This preserves
MAVEN_OPTS word splitting while preventing unintended shell expansion.
Fixes #11978
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The eval in the mvn script causes shell expansion of ${...} patterns
in user-provided arguments. This regression test exercises the actual
launcher script via setForkJvm(true) and verifies that ${...} is not
expanded by the shell.
Related: #11978
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gnodet
added a commit
that referenced
this pull request
May 19, 2026
- Use printf in mvn debug output so each user arg is shown individually quoted, preserving boundary information. - Trim IT Javadoc to match codebase style. - Reword assertion comments to make primary/secondary priority explicit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11983 to
maven-4.0.x.Fixes the
mvnshell script incorrectly expanding${...}placeholders in CLI arguments. Includes an integration test.Original author: Gerd Aschemann
Claude Code on behalf of Guillaume Nodet